Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3341#discussion_r20558172
  
    --- Diff: 
repl/scala-2.11/src/main/scala/org/apache/spark/repl/SparkILoop.scala ---
    @@ -61,11 +61,14 @@ class SparkILoop(in0: Option[BufferedReader], protected 
val out: JPrintWriter)
       def initializeSpark() {
         intp.beQuietDuring {
           command( """
    -         @transient val sc = 
org.apache.spark.repl.Main.createSparkContext();
    +         @transient val sc = {
    +           val _sc = org.apache.spark.repl.Main.createSparkContext()
    +           println("Spark context available as sc.")
    --- End diff --
    
    I think I misunderstood your question. The difference is if 
`org.apache.spark.repl.Main.createSparkContext()` throws an exception, the 
`println` won't be executed. The previous implementation will always execute 
`echo`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to