Github user srowen commented on the issue: https://github.com/apache/spark/pull/22683 Heh this change is actually narrowly wrong, but, is correct and needs to be larger in a broader sense. 1000 is the right factor for KB = kilobytes. 1024 is the right factor for KiB = kibibytes. Spark does generally use the factor 1024 everywhere internally (except one tiny usage I just found). But, all the log and UI messages say "kb" and "mb" and so on. This is incorrect. If you're willing, this change should really be about, at least, making this change and then updating all usages in the UI to indicate units like "KiB", "MiB", "GiB". What say?
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org