Github user kiszk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22976#discussion_r232443205
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
 ---
    @@ -154,7 +146,6 @@ object GenerateOrdering extends 
CodeGenerator[Seq[SortOrder], Ordering[InternalR
         // make sure INPUT_ROW is declared even if splitExpressions
         // returns an inlined block
         s"""
    --- End diff --
    
    Can we use just `code`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to