Github user mgaido91 commented on a diff in the pull request:
https://github.com/apache/spark/pull/22955#discussion_r232447827
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/PullOutPythonUDFInJoinConditionSuite.scala
---
@@ -50,20 +50,11 @@ class PullOutPythonUDFInJoinConditionSuite extends
PlanTest {
PythonEvalType.SQL_BATCHED_UDF,
udfDeterministic = true)
- val notSupportJoinTypes = Seq(LeftOuter, RightOuter, FullOuter, LeftAnti)
-
- test("inner join condition with python udf only") {
- val query = testRelationLeft.join(
- testRelationRight,
- joinType = Inner,
- condition = Some(pythonUDF))
- val expected = testRelationLeft.join(
- testRelationRight,
- joinType = Inner,
- condition = None).where(pythonUDF).analyze
+ val unsupportedJoinTypes = Seq(LeftOuter, RightOuter, FullOuter,
LeftAnti)
+ private def comparePlansWithConf(query: LogicalPlan, expected:
LogicalPlan): Unit = {
--- End diff --
better naming? what does it mean `WithConf`?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
