Github user MaxGekk commented on a diff in the pull request:
https://github.com/apache/spark/pull/23006#discussion_r232486935
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameReader.scala ---
@@ -491,7 +491,8 @@ class DataFrameReader private[sql](sparkSession:
SparkSession) extends Logging {
val parsedOptions: CSVOptions = new CSVOptions(
extraOptions.toMap,
sparkSession.sessionState.conf.csvColumnPruning,
- sparkSession.sessionState.conf.sessionLocalTimeZone)
+ sparkSession.sessionState.conf.sessionLocalTimeZone,
+ sparkSession.sessionState.conf.columnNameOfCorruptRecord)
--- End diff --
Do you mean:
```
def this(
parameters: Map[String, String],
columnPruning: Boolean,
defaultTimeZoneId: String,
defaultColumnNameOfCorruptRecord: String) = {...}
```
and
```
def this(
parameters: Map[String, String],
columnPruning: Boolean,
defaultTimeZoneId: String) = this(parameters, columnPruning,
defaultTimeZoneId, "")
```
? otherwise `one defaultColumnNameOfCorruptRecord with default value ""`
could be not compiled probably, but I will try.
Do you want to see that in this PR?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
