Github user MaxGekk commented on the issue:
https://github.com/apache/spark/pull/22429
@HyukjinKwon @cloud-fan Thank you for looking at the PR.
So, if I split the PR to 2 PRs:
1. Writing truncated plans to a file
2. Control number of fields in truncated strings.
, it would be better for review, right?
> I think it's okay to expose that number to toFile. I think this is an
internal API, right?
Yes, it is.
> People could just set whatever number they want I guess. Fix me if I
misread.
I just had a concern that there are much more places (~10) besides of the
`toFile` method where I have to pass some value for `maxFields`. In all such
places I have to read a SQL config.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
