Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23021#discussion_r233269827
--- Diff: python/pyspark/testing/sqlutils.py ---
@@ -0,0 +1,268 @@
+#
--- End diff --
Yea, similar thought. One thing is though testing util itself has some
dependencies to each others (for instance, `from pyspark.tests import
ReusedPySparkTestCase`). So, I thought it's okay to make it separate.
Another benefit from doing so is we can simply refer the example (NumPy) as
is. As you already know, NumPy has been there more then 15 years and should be
mature enough. It should be okay to trust their approach.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
