Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22598#discussion_r233627534
  
    --- Diff: 
core/src/main/scala/org/apache/spark/deploy/security/KafkaDelegationTokenProvider.scala
 ---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.spark.deploy.security
    +
    +import scala.language.existentials
    +import scala.util.control.NonFatal
    +
    +import org.apache.hadoop.conf.Configuration
    +import org.apache.hadoop.security.Credentials
    +
    +import org.apache.spark.SparkConf
    +import org.apache.spark.internal.Logging
    +import org.apache.spark.internal.config.{KAFKA_BOOTSTRAP_SERVERS, 
KAFKA_SECURITY_PROTOCOL}
    +
    +private[security] class KafkaDelegationTokenProvider
    +  extends HadoopDelegationTokenProvider with Logging {
    +
    +  override def serviceName: String = "kafka"
    +
    +  override def obtainDelegationTokens(
    +      hadoopConf: Configuration,
    +      sparkConf: SparkConf,
    +      creds: Credentials): Option[Long] = {
    +    try {
    +      logDebug("Attempting to fetch Kafka security token.")
    +      val (token, nextRenewalDate) = KafkaTokenUtil.obtainToken(sparkConf)
    +      creds.addToken(token.getService, token)
    +      return Some(nextRenewalDate)
    +    } catch {
    +      case NonFatal(e) =>
    +        logInfo(s"Failed to get token from service $serviceName", e)
    +    }
    +    None
    +  }
    +
    +  override def delegationTokensRequired(
    +      sparkConf: SparkConf,
    +      hadoopConf: Configuration): Boolean = {
    +    sparkConf.get(KAFKA_BOOTSTRAP_SERVERS).isDefined &&
    --- End diff --
    
    `sparkConf.contains(KAFKA_BOOTSTRAP_SERVERS)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to