Github user andrewor14 commented on the pull request:
https://github.com/apache/spark/pull/3368#issuecomment-63708850
Hey @coolfrood that depends on what we want `totalRegisteredExecutors` to
mean. If it means "the total count of all executors that have been registered
so far", then the current code is correct. If it means "the total count of
executors that are currently registered", then your patch is correct. Since
this is only used on start-up I think it's OK to change the meaning of it. I
would add a comment above `totalRegisteredExecutors` to clarify that it means
the latter, however. LGTM otherwise.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
