Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23044#discussion_r233819066
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateOrdering.scala
---
@@ -76,8 +76,6 @@ object GenerateOrdering extends
CodeGenerator[Seq[SortOrder], Ordering[InternalR
row: String,
ordering: Seq[SortOrder]): Seq[ExprCode] = {
ctx.INPUT_ROW = row
- // to use INPUT_ROW we must make sure currentVars is null
- ctx.currentVars = null
--- End diff --
I think the conclusion was to keep it?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
