Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/16732#discussion_r233901615
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/linalg/distributed/BlockMatrix.scala
 ---
    @@ -275,22 +275,33 @@ class BlockMatrix @Since("1.3.0") (
         val rows = blocks.flatMap { case ((blockRowIdx, blockColIdx), mat) =>
           mat.rowIter.zipWithIndex.map {
             case (vector, rowIdx) =>
    -          blockRowIdx * rowsPerBlock + rowIdx -> ((blockColIdx, 
vector.asBreeze))
    -      }
    +          blockRowIdx * rowsPerBlock + rowIdx -> ((blockColIdx, vector))
    +      }.filter(_._2._2.size > 0)
    --- End diff --
    
    You can drop the second filter now, right?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to