Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/23049
  
    I'm not sure this is actually helping much or making things less confusing.
    
    If `spark-env.sh` doesn't exist, your message will tell people to modify a 
file that doesn't exist.
    
    If it's triggered in a subsequent invocation of this script, where the file 
has already been loaded, it will just say `spark-env.sh` without its location, 
like before. So nothing is gained.
    
    `spark-env.sh` is actually documented in Spark's configuration doc. So if 
you want to point people at the doc instead, I could see that as an 
improvement. But you current change doesn't really change anything from before 
to me.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to