Github user squito commented on a diff in the pull request:
https://github.com/apache/spark/pull/22612#discussion_r234347011
--- Diff:
core/src/main/scala/org/apache/spark/metrics/ExecutorMetricType.scala ---
@@ -47,18 +65,39 @@ private[spark] abstract class
MBeanExecutorMetricType(mBeanName: String)
}
}
-case object JVMHeapMemory extends ExecutorMetricType {
+case object JVMHeapMemory extends SingleValueExecutorMetricType {
override private[spark] def getMetricValue(memoryManager:
MemoryManager): Long = {
ManagementFactory.getMemoryMXBean.getHeapMemoryUsage().getUsed()
}
}
-case object JVMOffHeapMemory extends ExecutorMetricType {
+case object JVMOffHeapMemory extends SingleValueExecutorMetricType {
override private[spark] def getMetricValue(memoryManager:
MemoryManager): Long = {
ManagementFactory.getMemoryMXBean.getNonHeapMemoryUsage().getUsed()
}
}
+case object ProcessTreeMetrics extends ExecutorMetricType {
+ override val names = Seq(
+ "ProcessTreeJVMVMemory",
+ "ProcessTreeJVMRSSMemory",
+ "ProcessTreePythonVMemory",
+ "ProcessTreePythonRSSMemory",
+ "ProcessTreeOtherVMemory",
+ "ProcessTreeOtherRSSMemory")
+ override private[spark] def getMetricValues(memoryManager:
MemoryManager): Array[Long] = {
--- End diff --
nit: blank line before this method
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
