Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23065#discussion_r234393743
--- Diff:
external/kinesis-asl/src/main/java/org/apache/spark/examples/streaming/JavaKinesisWordCountASL.java
---
@@ -105,25 +105,22 @@ public static void main(String[] args) throws
Exception {
String endpointUrl = args[2];
// Create a Kinesis client in order to determine the number of shards
for the given stream
- AmazonKinesisClient kinesisClient =
- new AmazonKinesisClient(new DefaultAWSCredentialsProviderChain());
- kinesisClient.setEndpoint(endpointUrl);
- int numShards =
-
kinesisClient.describeStream(streamName).getStreamDescription().getShards().size();
-
+ AmazonKinesis kinesisClient = AmazonKinesisClientBuilder.standard()
--- End diff --
Most of the Kinesis changes are of this form, to use the new client
builder, with the same argument going in as far as I can tell. The rest are
Java 8 cleanups.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
