Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23043#discussion_r234475858
--- Diff: common/unsafe/src/main/java/org/apache/spark/unsafe/Platform.java
---
@@ -120,6 +120,9 @@ public static float getFloat(Object object, long
offset) {
}
public static void putFloat(Object object, long offset, float value) {
+ if(value == -0.0f) {
--- End diff --
I'm fine to put this trick here, shall we also move the IsNaN logic to here
as well?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
