Github user rednaxelafx commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23079#discussion_r234508866
  
    --- Diff: 
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/optimizer/ReplaceNullWithFalseInPredicateSuite.scala
 ---
    @@ -298,6 +299,45 @@ class ReplaceNullWithFalseSuite extends PlanTest {
         testProjection(originalExpr = column, expectedExpr = column)
       }
     
    +  test("replace nulls in lambda function of ArrayFilter") {
    +    val cond = GreaterThan(UnresolvedAttribute("e"), Literal(0))
    --- End diff --
    
    Actually I intentionally made all three lambda the same (the `MapFilter` 
one only differs in the lambda parameter). I can encapsulate this lambda 
function into a test utility function. Let me update the PR and see what you 
think.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to