Github user drewrobb commented on the issue:
https://github.com/apache/spark/pull/23062
Thanks much for the prompt feedback. PTAL at changes. I had to modify the
ScroogeLikeExample class to make the additional DatasetSuite test work-- my
prior example had removed methods from the scrooge code that were actually
necessary. Kept as separate commits for review, but can squash later?
RE Scala 2.12 are there any specific things you are worried about I could
look at? I'm not super familiar with changes in 2.12, and I think 2.11 should
be fine, as this was developed using 2.11. And I assume the QA build is testing
on 2.12 also?
Also this might not be the place to ask but it is rather ungreppable-- have
you encountered compilation generated java files in ./org/ (that directory is
also not in .gitignore!) breaking compilation in sbt? In my development
environment I'll frequently have to delete that entire directory for
compilation to work again.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
