Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/23093#discussion_r235015293
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/classification/DecisionTreeClassifier.scala
---
@@ -91,7 +91,7 @@ class DecisionTreeClassifier @Since("1.4.0") (
/** @group setParam */
@Since("1.4.0")
- override def setImpurity(value: String): this.type = set(impurity, value)
+ def setImpurity(value: String): this.type = set(impurity, value)
--- End diff --
I think we can remove these too. I assumed they were meant to be deprecated
because the trait's implementation was deprecated, and there's no compelling
reason to only remove it from the trait. The point was to use set().
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
