Github user abehm commented on a diff in the pull request:
https://github.com/apache/spark/pull/23096#discussion_r235141963
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -102,29 +102,34 @@ class Analyzer(
this(catalog, conf, conf.optimizerMaxIterations)
}
- def executeAndCheck(plan: LogicalPlan): LogicalPlan =
AnalysisHelper.markInAnalyzer {
- val analyzed = execute(plan)
- try {
- checkAnalysis(analyzed)
- analyzed
- } catch {
- case e: AnalysisException =>
- val ae = new AnalysisException(e.message, e.line, e.startPosition,
Option(analyzed))
- ae.setStackTrace(e.getStackTrace)
- throw ae
+ def executeAndCheck(plan: LogicalPlan, tracker:
Option[QueryPlanningTracker]): LogicalPlan = {
+ AnalysisHelper.markInAnalyzer {
+ val analyzed = execute(plan, tracker)
+ try {
+ checkAnalysis(analyzed)
+ analyzed
+ } catch {
+ case e: AnalysisException =>
+ val ae = new AnalysisException(e.message, e.line,
e.startPosition, Option(analyzed))
+ ae.setStackTrace(e.getStackTrace)
+ throw ae
+ }
}
}
- override def execute(plan: LogicalPlan): LogicalPlan = {
+ override def execute(plan: LogicalPlan, tracker:
Option[QueryPlanningTracker]): LogicalPlan = {
--- End diff --
Do you intend to push this change into OSS? Looks like the signature of a
few major entry points are changed.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
