Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23057#discussion_r235237635
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/subquery.scala
 ---
    @@ -70,6 +67,26 @@ object RewritePredicateSubquery extends 
Rule[LogicalPlan] with PredicateHelper {
         case _ => joinPlan
       }
     
    +  private def rewriteDedupPlan(plan: LogicalPlan, rewrites: 
AttributeMap[Alias]): LogicalPlan = {
    +    val aliasedExpressions = plan.output.map { ref =>
    +      rewrites.getOrElse(ref, ref)
    +    }
    +    Project(aliasedExpressions, plan)
    +  }
    +
    +  private def dedupSubqueryOnSelfJoin(values: Seq[Expression], sub: 
LogicalPlan): LogicalPlan = {
    --- End diff --
    
    Add a simple code comment for this method?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to