Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/17654#discussion_r235562982
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/regression/LinearRegression.scala ---
@@ -444,31 +444,21 @@ class LinearRegressionModel private[ml] (
@Since("1.4.0") override val uid: String,
@Since("2.0.0") val coefficients: Vector,
@Since("1.3.0") val intercept: Double)
- extends RegressionModel[Vector, LinearRegressionModel]
- with LinearRegressionParams with MLWritable {
-
- private var trainingSummary: Option[LinearRegressionTrainingSummary] =
None
+ extends RegressionModel[Vector, LinearRegressionModel] with MLWritable
+ with LinearRegressionParams with
HasTrainingSummary[LinearRegressionTrainingSummary] {
override val numFeatures: Int = coefficients.size
+ private[ml]
+ override def setSummary(summary:
Option[LinearRegressionTrainingSummary]): this.type =
--- End diff --
Yeah, why do we need these definitions that just invoke the superclass
method?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
