Github user JoshRosen commented on the pull request:

    https://github.com/apache/spark/pull/2951#issuecomment-63769092
  
    @viper-kun No, I'm not actively working on this.  A pull request here would 
be _very_ welcome, since this is an annoying bug.  If you're planning to work 
on this, make sure to include the extra test cases that I added to 
`JavaAPISuite`; these tests should be useful regardless of what approach you 
taking to fixing these bugs.
    
    From a binary compatibility standpoint, it's important to keep the 
`Java*Like` interfaces since there's some code in the wild that uses these 
interfaces to abstract over the different implementations.  Removing default 
implementations from traits technically breaks compatibility for anyone who 
might have extended those traits, but I don't think that should be a huge 
concern / likely problem.
    
    If you want to avoid copying / moving everything around, then I think it 
would be sufficient to just identify the methods that are affected by this 
compiler bug and copy only those methods to each subclass.  We could maintain 
100% binary compatibility with this approach, even for the obscure case where 
someone extended a trait, and it might make it easier to backport the fix to 
maintenance branches, but it also seems sort of risk-prone because someone 
might add new default implementations in the trait.
    
    For the sake of keeping the discussion in one place, let's chat about 
alternative designs on the JIRA ticket.  I'll unassign myself from it and copy 
this comment over there.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to