Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23102#discussion_r235821628
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala 
---
    @@ -61,11 +62,12 @@ private[deploy] object DependencyUtils extends Logging {
           hadoopConf: Configuration,
           secMgr: SecurityManager): String = {
         val targetDir = Utils.createTempDir()
    +    val fileSeparator = Pattern.quote(System.getProperty("file.separator"))
         Option(jars)
           .map {
             resolveGlobPaths(_, hadoopConf)
               .split(",")
    -          .filterNot(_.contains(userJar.split("/").last))
    +          .filterNot(_.contains(userJar.split(fileSeparator).last))
    --- End diff --
    
    Just split on `File.separator`, not a regex.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to