Github user shahidki31 commented on a diff in the pull request:
https://github.com/apache/spark/pull/23088#discussion_r236087749
--- Diff:
core/src/test/scala/org/apache/spark/status/AppStatusStoreSuite.scala ---
@@ -77,6 +77,30 @@ class AppStatusStoreSuite extends SparkFunSuite {
assert(store.count(classOf[CachedQuantile]) === 2)
}
+ test("only successfull task have taskSummary") {
+ val store = new InMemoryStore()
+ (0 until 5).foreach { i => store.write(failedTaskData(i)) }
+ val appStore = new AppStatusStore(store).taskSummary(stageId,
attemptId, uiQuantiles)
+ assert(appStore.size === 0)
+ }
+
+ test("summary should contain task metrics of only successfull tasks") {
+ val store = new InMemoryStore()
+ (0 until 5).foreach { i =>
+ if (i % 2 == 1) store.write(failedTaskData(i))
+ else store.write(newTaskData(i))
+ }
+ val summary = new AppStatusStore(store).taskSummary(stageId,
attemptId, uiQuantiles).get
+
+ val values = (0 to 2).map( i =>
--- End diff --
Done
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
