Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17586#discussion_r236239347
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/ml/classification/LinearSVC.scala ---
    @@ -287,6 +290,27 @@ class LinearSVCModel private[classification] (
       @Since("2.2.0")
       def setWeightCol(value: Double): this.type = set(threshold, value)
     
    +  private var trainingSummary: Option[LinearSVCTrainingSummary] = None
    +
    +  private[classification]
    +  def setSummary(summary: Option[LinearSVCTrainingSummary]): this.type = {
    +    this.trainingSummary = summary
    +    this
    +  }
    +
    +  /**
    +   * Gets summary of model on training set. An exception is
    +   * thrown if `trainingSummary == None`.
    +   */
    +  @Since("2.2.0")
    +  def summary: LinearSVCTrainingSummary = trainingSummary.getOrElse(
    +    throw new SparkException("No training summary available for this 
LinearSVCModel")
    --- End diff --
    
    These should be marked Since 3.0.0 too.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to