Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23102#discussion_r236343465
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/DependencyUtils.scala 
---
    @@ -61,11 +61,13 @@ private[deploy] object DependencyUtils extends Logging {
           hadoopConf: Configuration,
           secMgr: SecurityManager): String = {
         val targetDir = Utils.createTempDir()
    +    val fileSeparator = Pattern.quote(File.separator)
    --- End diff --
    
    My bad. `separator` is a string and will be interpreted as a regex. Split 
on `File.separatorChar` instead and it will split as expected. No Pattern 
needed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to