Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/23136#discussion_r236431997
--- Diff:
resource-managers/kubernetes/core/src/test/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManagerSuite.scala
---
@@ -100,6 +101,18 @@ class ExecutorPodsLifecycleManagerSuite extends
SparkFunSuite with BeforeAndAfte
verify(schedulerBackend).doRemoveExecutor("1", expectedLossReason)
}
+ test("When an executor reaches error states immediately and the user has
set the flag" +
--- End diff --
could you write shorter test names? that makes it easier to actually
differentiate tests.
e.g. "keep executor pods in k8s if configured" says the same thing in a lot
less words.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
