Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23100#discussion_r236469693
--- Diff:
mllib/src/main/scala/org/apache/spark/ml/feature/OneHotEncoder.scala ---
@@ -17,126 +17,512 @@
package org.apache.spark.ml.feature
+import org.apache.hadoop.fs.Path
--- End diff --
Yea, I've tried to remove old `OneHotEncoder` first and then do renaming.
The git diff is still like this:
https://github.com/apache/spark/compare/master...viirya:remove_one_hot_encoder_test?expand=1
I'm ok if you prefer to have two PRs. WDYT? @srowen
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
