Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23128#discussion_r236636819
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/ShuffledRowRDD.scala ---
@@ -154,7 +156,14 @@ class ShuffledRowRDD(
override def compute(split: Partition, context: TaskContext):
Iterator[InternalRow] = {
val shuffledRowPartition = split.asInstanceOf[ShuffledRowRDDPartition]
- val metrics = context.taskMetrics().createTempShuffleReadMetrics()
+ val tempMetrics = context.taskMetrics().createTempShuffleReadMetrics()
+ // metrics here could be empty cause user can use ShuffledRowRDD
directly,
--- End diff --
I don't think we need to consider this case since `ShuffledRowRDD` is a
private API. If we do need to consider it, we also need to take care if users
pass in a `metrics` that is invalid.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
