Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23130#discussion_r236705666
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/sources/SaveLoadSuite.scala ---
    @@ -142,4 +143,15 @@ class SaveLoadSuite extends DataSourceTest with 
SharedSQLContext with BeforeAndA
           assert(e.contains(s"Partition column `$unknown` not found in schema 
$schemaCatalog"))
         }
       }
    +
    +  test("skip empty files in load") {
    +    withTempDir { dir =>
    +      val path = dir.getCanonicalPath
    +      Files.write(Paths.get(path, "empty"), Array.empty[Byte])
    +      Files.write(Paths.get(path, "notEmpty"), "a".getBytes)
    --- End diff --
    
    Nit for consistency: `.getBytes(StandardCharsets.UTF_8)`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to