Github user BryanCutler commented on a diff in the pull request:

    https://github.com/apache/spark/pull/21465#discussion_r236881042
  
    --- Diff: python/pyspark/ml/regression.py ---
    @@ -1030,9 +1056,9 @@ def featureImportances(self):
     
     
     @inherit_doc
    -class GBTRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, 
HasPredictionCol, HasMaxIter,
    -                   GBTParams, HasCheckpointInterval, HasStepSize, HasSeed, 
JavaMLWritable,
    -                   JavaMLReadable, TreeRegressorParams):
    +class GBTRegressor(JavaEstimator, HasFeaturesCol, HasLabelCol, 
HasPredictionCol, GBTParams,
    +                   HasCheckpointInterval, HasStepSize, HasSeed, 
JavaMLWritable, JavaMLReadable,
    --- End diff --
    
    I think you can remove `HasStepSize` since it is in `GBTParams`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to