Github user heary-cao commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237344805
--- Diff: core/src/test/scala/org/apache/spark/SparkFunSuite.scala ---
@@ -105,5 +105,16 @@ abstract class SparkFunSuite
logInfo(s"\n\n===== FINISHED $shortSuiteName: '$testName' =====\n")
}
}
-
+ /**
+ * Creates a temporary directory, which is then passed to `f` and will
be deleted after `f`
+ * returns.
+ *
+ * @todo Probably this method should be moved to a more general place
+ */
+ protected def withCreateTempDir(f: File => Unit): Unit = {
--- End diff --
I'm not sure if I need `assert(spark.sparkContext.statusTracker
.getExecutorInfos.map(_.numRunningTasks()).sum == 0)`. after all, `protected
def spark: SparkSession` defined in `SQLTestData`. Unless we construct one
`waitForTasksToFinish ` look like
```
protected def waitForTasksToFinish(): Unit = {
eventually(timeout(10.seconds)) {
}
}
```
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
