Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/3377#discussion_r20689898
  
    --- Diff: bin/run-example ---
    @@ -35,9 +35,9 @@ else
     fi
     
     if [ -f "$FWDIR/RELEASE" ]; then
    -  export SPARK_EXAMPLES_JAR="`ls "$FWDIR"/lib/spark-examples-*hadoop*.jar`"
    -elif [ -e 
"$EXAMPLES_DIR"/target/scala-$SPARK_SCALA_VERSION/spark-examples-*hadoop*.jar 
]; then
    -  export SPARK_EXAMPLES_JAR="`ls 
"$EXAMPLES_DIR"/target/scala-$SPARK_SCALA_VERSION/spark-examples-*hadoop*.jar`"
    +  export SPARK_EXAMPLES_JAR="`ls -t 
"$FWDIR"/lib/spark-examples-*hadoop*.jar 2>>/dev/null | head -1`"
    --- End diff --
    
    How do you know this will pick up the right jar?
    
    More generally, I think the only situation someone will run into this is 
when switching between branches and rebuilding without cleaning. Not sure it's 
worth it to add workarounds in the code for that.
    
    You'll get a similar error from `compute-classpath.sh` if multiple assembly 
jars exist. The same behavior should be just fine for the examples.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to