Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/23152#discussion_r237347496
--- Diff:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/statsEstimation/FilterEstimationSuite.scala
---
@@ -821,6 +822,32 @@ class FilterEstimationSuite extends
StatsEstimationTestBase {
expectedRowCount = 3)
}
+ test("ColumnStatsMap tests") {
--- End diff --
Since this is not correct, I think that FilterEstimation didn't work
previously. Can you also add a related test using validateEstimatedStats
similar to other tests? In the test, we should rely on min and max stats to do
filter estimation.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
