Github user vanzin commented on a diff in the pull request: https://github.com/apache/spark/pull/22598#discussion_r237620333 --- Diff: core/src/main/scala/org/apache/spark/internal/config/package.scala --- @@ -688,4 +688,65 @@ package object config { .stringConf .toSequence .createWithDefault(Nil) + + private[spark] val KAFKA_BOOTSTRAP_SERVERS = --- End diff -- This pattern was added after you PR, but since it's there... might be better to put these into a new file (e.g. `Kafka.scala`) in this package, instead of adding more stuff to this file. (e.g. see `History.scala`)
--- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org