Github user skonto commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23136#discussion_r237642388
  
    --- Diff: 
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/scheduler/cluster/k8s/ExecutorPodsLifecycleManager.scala
 ---
    @@ -30,7 +30,7 @@ import org.apache.spark.scheduler.ExecutorExited
     import org.apache.spark.util.Utils
     
     private[spark] class ExecutorPodsLifecycleManager(
    -    conf: SparkConf,
    +    val conf: SparkConf,
    --- End diff --
    
    @onursatici I think its a small bug fix that can be include dhere, I can 
update the PR description if that helps. I thought of creating a new one but 
exposing that value was easy for testing purposes. 
    I don't expect that to be a problem unless someone tries to modify 
SparkConf at the backend when he shouldnt. I dont thinkg it is not a big 
concern.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to