Github user HyukjinKwon commented on a diff in the pull request:
https://github.com/apache/spark/pull/23151#discussion_r237746374
--- Diff:
core/src/test/scala/org/apache/spark/deploy/SparkSubmitSuite.scala ---
@@ -1134,39 +1130,40 @@ class SparkSubmitSuite
val hadoopConf = new Configuration()
updateConfWithFakeS3Fs(hadoopConf)
- val tmpDir = Utils.createTempDir()
- val pyFile = File.createTempFile("tmpPy", ".egg", tmpDir)
+ withTempDir { tmpDir =>
+ val pyFile = File.createTempFile("tmpPy", ".egg", tmpDir)
- val args = Seq(
- "--class", UserClasspathFirstTest.getClass.getName.stripPrefix("$"),
- "--name", "testApp",
- "--master", "yarn",
- "--deploy-mode", "client",
- "--py-files", s"s3a://${pyFile.getAbsolutePath}",
- "spark-internal"
- )
+ val args = Seq(
+ "--class",
UserClasspathFirstTest.getClass.getName.stripPrefix("$"),
+ "--name", "testApp",
+ "--master", "yarn",
+ "--deploy-mode", "client",
+ "--py-files", s"s3a://${pyFile.getAbsolutePath}",
+ "spark-internal"
+ )
- val appArgs = new SparkSubmitArguments(args)
- val (_, _, conf, _) = submit.prepareSubmitEnvironment(appArgs, conf =
Some(hadoopConf))
+ val appArgs = new SparkSubmitArguments(args)
+ val (_, _, conf, _) = submit.prepareSubmitEnvironment(appArgs, conf
= Some(hadoopConf))
- conf.get(PY_FILES.key) should be (s"s3a://${pyFile.getAbsolutePath}")
- conf.get("spark.submit.pyFiles") should (startWith("/"))
+ conf.get(PY_FILES.key) should be(s"s3a://${pyFile.getAbsolutePath}")
--- End diff --
ditto. Technically it should better be assert and avoid infix notation but
I think we don't have to do it here.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
