Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22514#discussion_r237756348
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/CreateHiveTableAsSelectCommand.scala
 ---
    @@ -95,9 +77,98 @@ case class CreateHiveTableAsSelectCommand(
         Seq.empty[Row]
       }
     
    +  def getDataWritingCommand(
    --- End diff --
    
    I feel it's better to have 2 methods: `writingCommandForExistingTable`, 
`writingCommandForNewTable`


---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to