Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/23189
  
    Actually the problem is here:
    
    ```
          case e: ClassNotFoundException =>
            logWarning(s"Failed to load $childMainClass.", e)
    ```
    
    That particular `logWarning` is not overridden in the SparkSubmit object:
    
    ```
      override def main(args: Array[String]): Unit = {
        val submit = new SparkSubmit() {
          ...
          override protected def logWarning(msg: => String): Unit = 
printMessage(s"Warning: $msg")
    ```
    
    Probably should instead use the same `logWarning` call as the other handler 
below:
    
    ```
          case e: NoClassDefFoundError =>
            logWarning(s"Failed to load $childMainClass: ${e.getMessage()}")
    ```
    
    Which should then always print the error regardless of your log4j 
configuration.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to