Github user rdblue commented on a diff in the pull request:
https://github.com/apache/spark/pull/21306#discussion_r237971092
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalog/v2/PartitionTransforms.java
---
@@ -0,0 +1,229 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalog.v2;
+
+/**
+ * A standard set of transformations that are passed to data sources
during table creation.
+ *
+ * @see PartitionTransform
+ */
+public class PartitionTransforms {
+ private PartitionTransforms() {
+ }
+
+ /**
+ * Create a transform for a column with the given name.
+ * <p>
+ * This transform is used to pass named transforms that are not known to
Spark.
+ *
+ * @param transform a name of the transform to apply to the column
+ * @param colName a column name
+ * @return an Apply transform for the column
+ */
+ public static PartitionTransform apply(String transform, String colName)
{
+ if ("identity".equals(transform)) {
--- End diff --
What I wanted to discuss on Wednesday was how to pass these transforms.
@rxin and I had some discussions about it on the dev list, but we didn't come
up with a decision. I think the solution will probably be to add way to pass
generic function application and a list of arguments that are either columns or
constant literals.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
