Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23088#discussion_r238110723
  
    --- Diff: core/src/main/scala/org/apache/spark/status/AppStatusStore.scala 
---
    @@ -221,29 +230,49 @@ private[spark] class AppStatusStore(
         // stabilize once the stage finishes. It's also slow, especially with 
disk stores.
         val indices = quantiles.map { q => math.min((q * count).toLong, count 
- 1) }
     
    +    // TODO Summary metrics needs to display all the successful tasks' 
metrics (SPARK-26119).
    --- End diff --
    
    It's not ideal but it's a reasonable solution. Are you OK with it @vanzin ?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to