Github user maropu commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23194#discussion_r238256563
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala 
---
    @@ -377,41 +377,42 @@ abstract class DDLSuite extends QueryTest with 
SQLTestUtils {
         }
       }
     
    -  test("CTAS a managed table with the existing empty directory") {
    -    val tableLoc = new 
File(spark.sessionState.catalog.defaultTablePath(TableIdentifier("tab1")))
    -    try {
    +  protected def withTableLocation(tableNames: String)(f: File => Unit): 
Unit = {
    --- End diff --
    
    How about `withEmptyDirInTablePath(dirName: String)`?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to