Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/23204#discussion_r238257371
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/aggregate/HashAggregateExec.scala
---
@@ -63,7 +63,7 @@ case class HashAggregateExec(
"peakMemory" -> SQLMetrics.createSizeMetric(sparkContext, "peak
memory"),
"spillSize" -> SQLMetrics.createSizeMetric(sparkContext, "spill size"),
"aggTime" -> SQLMetrics.createTimingMetric(sparkContext, "aggregate
time"),
- "avgHashProbe" -> SQLMetrics.createAverageMetric(sparkContext, "avg
hash probe"))
+ "avgHashmapProbe" -> SQLMetrics.createAverageMetric(sparkContext, "avg
hashmap probe"))
--- End diff --
I know it's easy to just run the `git revert` command, but I'd like to
manually revert it, since that PR was merged long time ago. And we should still
keep changes like this renaming, as they are not quite related to the
performance regression.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
