Github user BryanCutler commented on a diff in the pull request:
https://github.com/apache/spark/pull/23203#discussion_r238868565
--- Diff: python/run-tests.py ---
@@ -93,17 +93,18 @@ def run_individual_python_test(target_dir, test_name,
pyspark_python):
"pyspark-shell"
]
env["PYSPARK_SUBMIT_ARGS"] = " ".join(spark_args)
-
- LOGGER.info("Starting test(%s): %s", pyspark_python, test_name)
+ str_test_name = " ".join(test_name)
+ LOGGER.info("Starting test(%s): %s", pyspark_python, str_test_name)
start_time = time.time()
try:
per_test_output = tempfile.TemporaryFile()
retcode = subprocess.Popen(
- [os.path.join(SPARK_HOME, "bin/pyspark"), test_name],
--- End diff --
Just a thought, could you leave `test_name` as a string and then change
this line to `[os.path.join(SPARK_HOME, "bin/pyspark")] + test_name.split(),`?
I think it would be a little more simple and wouldn't need `str_test_name`,
wdyt?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
