Github user xuanyuanking commented on a diff in the pull request:
https://github.com/apache/spark/pull/23207#discussion_r239050549
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/metric/SQLMetricsSuite.scala
---
@@ -170,13 +172,23 @@ class SQLMetricsSuite extends SparkFunSuite with
SQLMetricsTestUtils with Shared
val df = testData2.groupBy().agg(collect_set('a)) // 2 partitions
testSparkPlanMetrics(df, 1, Map(
2L -> (("ObjectHashAggregate", Map("number of output rows" -> 2L))),
+ 1L -> (("Exchange", Map(
+ "shuffle records written" -> 2L,
+ "records read" -> 2L,
+ "local blocks fetched" -> 2L,
--- End diff --
I agree "fetch" is a more code name in `ShuffleBlockFetcherIterator`, but
do you mean just change the display in ui? Cause there's many place even
api.scala use the name `localBlocksFetched`, change them all maybe not a good
choice for code backport, WDYT?
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
