Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23072#discussion_r239194803
  
    --- Diff: R/pkg/R/mllib_clustering.R ---
    @@ -610,3 +616,58 @@ setMethod("write.ml", signature(object = "LDAModel", 
path = "character"),
               function(object, path, overwrite = FALSE) {
                 write_internal(object, path, overwrite)
               })
    +
    +#' PowerIterationClustering
    +#'
    +#' A scalable graph clustering algorithm. Users can call 
\code{spark.assignClusters} to
    +#' return a cluster assignment for each input vertex.
    +#'
    +#  Run the PIC algorithm and returns a cluster assignment for each input 
vertex.
    +#' @param data A SparkDataFrame.
    +#' @param k The number of clusters to create.
    +#' @param initMode Param for the initialization algorithm.
    +#' @param maxIter Param for maximum number of iterations.
    +#' @param sourceCol Param for the name of the input column for source 
vertex IDs.
    +#' @param destinationCol Name of the input column for destination vertex 
IDs.
    --- End diff --
    
    nit. Here, `Name` -> `Param for the name` for consistency with the other 
param descriptions?
    
    Or, is it better to remote `Param for` prefix in other descriptions?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to