Github user Ngone51 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23223#discussion_r239316424
  
    --- Diff: 
resource-managers/yarn/src/test/scala/org/apache/spark/deploy/yarn/YarnAllocatorSuite.scala
 ---
    @@ -114,13 +116,20 @@ class YarnAllocatorSuite extends SparkFunSuite with 
Matchers with BeforeAndAfter
           clock)
       }
     
    -  def createContainer(host: String, resource: Resource = 
containerResource): Container = {
    -    val containerId = ContainerId.newContainerId(appAttemptId, 
containerNum)
    +  def createContainer(
    +      host: String,
    +      containerId: ContainerId = ContainerId.newContainerId(appAttemptId, 
containerNum),
    --- End diff --
    
    Good idea.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to