Github user MaxGekk commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23201#discussion_r239547742
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/json/JsonInferSchema.scala
 ---
    @@ -121,7 +122,26 @@ private[sql] class JsonInferSchema(options: 
JSONOptions) extends Serializable {
                 DecimalType(bigDecimal.precision, bigDecimal.scale)
             }
             decimalTry.getOrElse(StringType)
    -      case VALUE_STRING => StringType
    +      case VALUE_STRING =>
    +        val stringValue = parser.getText
    --- End diff --
    
    `DateType` is not inferred at all but there is another type inference code 
that could be shared between JSON and CSV (maybe somewhere else).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to