Github user rdblue commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23208#discussion_r239559037
  
    --- Diff: 
sql/core/src/main/java/org/apache/spark/sql/sources/v2/TableProvider.java ---
    @@ -25,7 +25,10 @@
      * The base interface for v2 data sources which don't have a real catalog. 
Implementations must
      * have a public, 0-arg constructor.
      * <p>
    - * The major responsibility of this interface is to return a {@link Table} 
for read/write.
    + * The major responsibility of this interface is to return a {@link Table} 
for read/write. If you
    + * want to allow end-users to write data to non-existing tables via write 
APIs in `DataFrameWriter`
    + * with `SaveMode`, you must return a {@link Table} instance even if the 
table doesn't exist. The
    + * table schema can be empty in this case.
    --- End diff --
    
    What does it mean to write to a non-existing table? If you're writing 
somewhere, the table must exist.
    
    This is for creating a table directly from configuration and an 
implementation class in the DataFrameWriter API. The target of the write still 
needs to exist.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to