Github user dongjoon-hyun commented on a diff in the pull request:

    https://github.com/apache/spark/pull/23072#discussion_r239700056
  
    --- Diff: R/pkg/vignettes/sparkr-vignettes.Rmd ---
    @@ -968,6 +970,17 @@ predicted <- predict(model, df)
     head(predicted)
     ```
     
    +#### Power Iteration Clustering
    +
    +Power Iteration Clustering (PIC) is a scalable graph clustering algorithm. 
`spark.assignClusters` method runs the PIC algorithm and returns a cluster 
assignment for each input vertex.
    +
    +```{r}
    +df <- createDataFrame(list(list(0L, 1L, 1.0), list(0L, 2L, 1.0),
    +                      list(1L, 2L, 1.0), list(3L, 4L, 1.0),
    --- End diff --
    
    Do we have an indentation rule for this? This PR is using two types of 
indentations for the same statements.
    - For docs (sparkr-vignettes.Rmd, mllib_clustering.R), this line is aligned 
with the first `list`.
    - For real code (test_mllib_clustering.R, powerIterationClustering.R), this 
line is aligned with the second `list`.
    
    Can we use the same indentation rule?



---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to